This repository was archived by the owner on Nov 17, 2023. It is now read-only.
Correct init idx2name on multi-CPU/GPU training for FeedForward#2366
Merged
tqchen merged 4 commits intoapache:masterfrom Jun 8, 2016
Merged
Correct init idx2name on multi-CPU/GPU training for FeedForward#2366tqchen merged 4 commits intoapache:masterfrom
tqchen merged 4 commits intoapache:masterfrom
Conversation
This patch is related to apache#2327 and apache#2337, which fix a bug of idx2name in multi-GPU environment for Module. Note, all previous codes which involved lr_mult and wd_mult in multi-GPU environment may suffer from this bug, for example, finetuning with lr_mult of lower layers fixed to zero on multi-GPU will give incorrect result.
This was referenced Jun 7, 2016
| fix_gamma=False, | ||
| momentum=bn_momentum, | ||
| # Same with https://github.com/soumith/cudnn.torch/blob/master/BatchNormalization.lua | ||
| eps=1e-5 |
Contributor
There was a problem hiding this comment.
change to 2e-5 instead of removing
Contributor
|
@tqchen good for merging after test finishes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch is related to #2327 and #2337, which fix a bug of
idx2namein multi-GPU environment for Module.Note, all previous codes which involved
lr_multandwd_multin multi-GPU environment may suffer from this bug,for example, finetuning with
lr_multof lower layers fixed to zero on multi-GPU will give incorrect result.With this patch, the ResNet example works on multi-GPU setting: