MINIFICPP-679: Make minor changes for const correctness improvements - #442
Closed
phrocker wants to merge 2 commits into
Closed
MINIFICPP-679: Make minor changes for const correctness improvements#442phrocker wants to merge 2 commits into
phrocker wants to merge 2 commits into
Conversation
phrocker
force-pushed
the
MINIFICPP-679
branch
from
November 15, 2018 22:55
12fe6cc to
c0b3bfc
Compare
phrocker
force-pushed
the
MINIFICPP-679
branch
from
November 15, 2018 23:00
c0b3bfc to
cbd8629
Compare
phrocker
commented
Nov 15, 2018
| uuid_ = other.uuid_; | ||
| //uuid_copy(uuid_, other.uuid_); | ||
| } | ||
|
|
Contributor
Author
There was a problem hiding this comment.
should be safe since we added a non trial move con to ident, but this will require some testing on all platforms. again, still running windows build. Will probably report back tomorrow.
apiri
approved these changes
Nov 19, 2018
apiri
pushed a commit
to apiri/nifi-minifi-cpp
that referenced
this pull request
Nov 19, 2018
This closes apache#442. Signed-off-by: Aldrin Piri <aldrin@apache.org>
nghiaxlee
pushed a commit
to nghiaxlee/nifi-minifi-cpp
that referenced
this pull request
Jul 8, 2019
This closes apache#442. Signed-off-by: Aldrin Piri <aldrin@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running a windows build now. If I see errors there I'll re-submit, but ran general tests and build across a variety of platforms.
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically master)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.