Skip to content

MINIFICPP-1239 Use <regex> except in gcc < 4.9 - #796

Closed
fgerlits wants to merge 1 commit into
apache:masterfrom
fgerlits:MINIFICPP-1239
Closed

MINIFICPP-1239 Use <regex> except in gcc < 4.9#796
fgerlits wants to merge 1 commit into
apache:masterfrom
fgerlits:MINIFICPP-1239

Conversation

@fgerlits

Copy link
Copy Markdown
Contributor

Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.

Description of PR

We should use the regular expression implementation from the STL whenever we can, which means for all compilers except gcc versions before 4.9.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file?
  • If applicable, have you updated the NOTICE file?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

@hunyadi-dev hunyadi-dev left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@arpadboda arpadboda left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arpadboda arpadboda closed this in b6ebce7 May 26, 2020
@fgerlits
fgerlits deleted the MINIFICPP-1239 branch July 13, 2020 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants