Skip to content

MINIFICPP-1313 Do a multifile lookup in onSchedule#859

Closed
fgerlits wants to merge 1 commit intoapache:mainfrom
fgerlits:MINIFICPP-1313-Make-sure-multifile-lookup-happens-right-after-reboot
Closed

MINIFICPP-1313 Do a multifile lookup in onSchedule#859
fgerlits wants to merge 1 commit intoapache:mainfrom
fgerlits:MINIFICPP-1313-Make-sure-multifile-lookup-happens-right-after-reboot

Conversation

@fgerlits
Copy link
Copy Markdown
Contributor

@fgerlits fgerlits commented Aug 3, 2020

https://issues.apache.org/jira/browse/MINIFICPP-1313

Do a first multifile lookup in onSchedule() to make sure TailFile can see the files which were already present before minifi started. This fixes an intermittent CI failure caused by TailFileTests running on the virtual machine less than 10 minutes after bootup.


Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file?
  • If applicable, have you updated the NOTICE file?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

@fgerlits fgerlits force-pushed the MINIFICPP-1313-Make-sure-multifile-lookup-happens-right-after-reboot branch from 13662b7 to be2416a Compare August 4, 2020 07:51
Copy link
Copy Markdown
Contributor

@arpadboda arpadboda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change itself looks good, my comment might end in a follow-up.

@arpadboda arpadboda closed this in 41fc5ae Aug 6, 2020
@fgerlits fgerlits deleted the MINIFICPP-1313-Make-sure-multifile-lookup-happens-right-after-reboot branch May 31, 2021 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants