WIP: MINIFICPP-1318 move test rocksdb state to /var/tmp#863
WIP: MINIFICPP-1318 move test rocksdb state to /var/tmp#863szaszm wants to merge 2 commits intoapache:mainfrom
Conversation
fgerlits
left a comment
fgerlits
left a comment
There was a problem hiding this comment.
There are a lot more:
~/src/minifi$ git grep '"/tmp' | wc -l
147
the rest do not need to be changed?
They are fine as long as we don't try to create a rocksdb database there. The problem is that rocksdb is configured to use direct IO, i.e. bypass the page cache, but tmpfs is just a mounted page cache without backing storage, so it makes no sense to use direct IO there. |
|
@szaszm : not sure if the CI failures we face on U16 jobs are related or not, but I would prefer to investigate before proceeding with this. |
szaszm
changed the title
I am 99% sure that both of those failures in TailFileTests are due to the bug fixed in #859. That PR has been merged now, so rebasing on top of it should get rid of the test failures. |
commit d5d1654 Author: Adam Debreceni <adam.debreceni@protonmail.com> Date: Thu Aug 6 11:25:25 2020 +0200 MINIFICPP-1312 - Remove unnecessary duration_cast commit 841cd73 Author: Adam Debreceni <adam.debreceni@protonmail.com> Date: Thu Aug 6 09:59:51 2020 +0200 MINIFICPP-1312 - Review changes commit c4394dc Author: Adam Debreceni <adam.debreceni@protonmail.com> Date: Tue Aug 4 15:10:13 2020 +0200 MINIFICPP-1312 - Review changes commit 267d5a4 Author: Adam Debreceni <adam.debreceni@protonmail.com> Date: Tue Aug 4 13:56:46 2020 +0200 MINIFICPP-1312 - Remove some more logs commit 85e191d Author: Adam Debreceni <adam.debreceni@protonmail.com> Date: Tue Aug 4 13:55:07 2020 +0200 MINIFICPP-1312 - Remove extra log messages commit 9584fff Author: Adam Debreceni <adam.debreceni@protonmail.com> Date: Mon Aug 3 15:56:15 2020 +0200 MINIFICPP-1312 - Busy wait for condition commit 76406ef Author: Adam Debreceni <adam.debreceni@protonmail.com> Date: Mon Aug 3 11:33:47 2020 +0200 MINIFICPP-1312 - More logs commit ba23458 Author: Adam Debreceni <adam.debreceni@protonmail.com> Date: Mon Aug 3 10:21:02 2020 +0200 MINIFICPP-1312 - More logs commit 68c6efd Author: Adam Debreceni <adam.debreceni@protonmail.com> Date: Mon Aug 3 09:50:42 2020 +0200 MINIFICPP-1312 - Linter fix commit 114fa50 Author: Adam Debreceni <adam.debreceni@protonmail.com> Date: Mon Aug 3 09:19:58 2020 +0200 MINIFICPP-1312 - Log generously Signed-off-by: Marton Szasz <szaszm01@gmail.com>
| auto root = testController.root_; | ||
|
|
||
| int timeout_ms = 1000; | ||
| unsigned int timeout_ms = 1000; |
There was a problem hiding this comment.
As this is a duration its type could also be std::chrono::duration, with no _ms suffix needed then.
5 participants
Missed TailFileTests state storage in #862
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically main)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.