NIFI-15598: When enabling referenced controller services in a connect…#10897
Open
markap14 wants to merge 70 commits intoapache:NIFI-15258from
Open
NIFI-15598: When enabling referenced controller services in a connect…#10897markap14 wants to merge 70 commits intoapache:NIFI-15258from
markap14 wants to merge 70 commits intoapache:NIFI-15258from
Conversation
Introduced comprehensive REST endpoints for managing Connectors through the NiFi web interface and API clients. Key capabilities: - Full lifecycle management (create, read, update, delete) - Start/stop control with run status endpoints - Multi-step configuration with property groups supporting string literals, asset references, and secret references - Asynchronous configuration verification with polling support - Access to connector's managed flow and process group status - Search functionality within connector's encapsulated flow Cluster support: - Request replication across cluster nodes - Response merging for dynamic property allowable values that may differ between nodes - Consistent configuration step and property descriptor handling Infrastructure: - Audit logging for all connector configuration changes - Authorization integration with NiFi's policy framework - UI extension support for connector-specific interfaces - Frontend updates for connector access policy management
… ConfigurationStep are unique (apache#10626) * NIFI-15322: Huge refactoring of Connectors to require that <Step Name, Property Name> tuple is unique. Requiring that is simple, but now that we enforce that, we can greatly simplify much of the code. * NIFI-15322: Added StepConfiguration to simplify API rather than using Map<String, ConnectorValueReference> in some places * NIFI-15322: Now that we enforce unique property names per step, introduced StepConfigurationContext to further reduce API complexity Signed-off-by: Kevin Doran <kdoran@apache.org>
…he#10631) NIFI-15322: Adapting to new connector configuration step model.
…r; updated mock framework to support secrets; validation cleanup (apache#10638)
…derSecretProvider to provide the Parameter Provider as the associated Authorizable (apache#10644)
apache#10654) * NIFI-15352: Added ConnectorClient to toolkit-cli so that it can be used in system tests; created system tests for Connectors; bug fixes found running tests; updated Secret/SecretReference to support fully qualified names * NIFI-15352: Addressed review feedback
apache#10645) * NIFI-15343: Adding an endpoint to return available secrets to the connector configuration wizard. * NIFI-15343: Adding providerId to SecretDTO. * NIFI-15343: Skipping ParameterProviders that are invalid or validating when fetching secrets. * NIFI-15343: Adding fully qualified name to SecretDTO. - Fixing rebase issue. This closes apache#10645
- Support multiple asset references - Clean up of assets in StandardConnectorDAO after apply and discard - Add endpoint for listing assets for a given connector - Add endpoint for discarding the working config of a connector - Add endpoint for retrieving asset content - Add system test for connectors that uploads an asset Signed-off-by: Kevin Doran <kdoran@apache.org> * Fix issues after rebasing, enable ClusteredConnectorAssetsIT
apache#10667) * NIFI-15361: Allowing configuration step documentation to be returned independent of any connector instances.
…onStep,Property) tuple (apache#10669)
apache#10665) * NIFI-15367: Ensure that Connectors' implicit parameter contexts are not registered with ParameterContextManager; added system test to verify; fixed bug in ConnectorAssetsIT where it did not wait for connector to return to its 'STOPPED' state before attempting to delete * NIFI-15367: Bug fixes; review feedback
…eate process groups if they have a connector ID. (apache#10673)
…ache#10683) * NIFI-15353: Adding support for rendering Connector Documentation. * NIFI-15353: Addressing review feedback. * NIFI-15353: Using mergeMap instead of switchMap to allow for concurrent doc loading. This closes apache#10683
apache#10732) * NIFI-15429: Adding an optional query parameter for specifying which process group should be returned within the Connectors flow. * NIFI-15429: Including managed process group id in the ConnectorDTO. * NIFI-15429: Addressing review feedback. * NIFI-15429: Updating path for fetching a Connector flow to require the desired Process Group ID. * NIFI-15429: Fixing failing unit test.
apache#10733) * NIFI-15430: Ensure that if we fail to initialize a Connector, we create a GhostConnector instead and ensure that we also proivde the extensionMissing flag on ConnectorNode * NIFI-15430: Added extensionMissing flag to Connector DTO * NIFI-15430: If unable to load initial flow of a Connector, make ghosted connector instead
apache#10730) * NIFI-15427: Added abiliy to drop flowfiles / drain flowfiles from a Connector; added some system tests to verify existing behavior; fixed existing issue with IT * NIFI-15427: Fixed Exception message in case unable to purge FlowFiles due to Connector state * NIFI-15427: Ensured thread safety of state transitions when draining/purging FlowFiles * NIFI-15427: Addressed review feedback
apache#10736) * NIFI-15433: If connector validation throws an Exception keep trying until it completes (with a timeout between retries); some bug fixes * NIFI-15433: Addressed review feedback * NIFI-15433: Fixed failing unit tests
apache#10749) * NIFI-15445: Removed 'disabled' state from Connectors; also fixed bug to ensure that if we fail to apply an update to a Connector that we stop it. * NIFI-15445: Addressed review feedback * NIFI-15445: Fixed checkstyle
* NIFI-15440: Implementation of ConnectorActions * NIFI-15440: Addressed review feedback * NIFI-15440: Addressed issues that occurred after rebase * NIFI-15440: Addressed review feedback
apache#10742) * NIFI-15439: Ensure that Process Groups are accessible from the appropriate endpoint but not accessible elsewhere * NIFI-15439: FlowAnalyzingRegistryClient should use an explicit Connector ID of null when retrieving Process Group from FlowManager
…a Ghost Connector is created (apache#10775) This closes apache#10775
apache#10806) * NIFI-15495 Restart Connectors that reference assets that were synchronized - Ensure Connectors re-resolve property values before starting - Ensure asset clean up happens only after applyUpdate fully finishes - Add connector asset properties to default nifi.properties * Fix system test * Encapsulate restart logic in new method on ConnectorNode * Fix JavaDoc
Add verifyCreate to ConnectorDAO and test cases
apache#10811) * NIFI-15467: Ensure that Connectors' versions are automatically resolved on startup - Allow connectors to specify Bundle Compatability when updating flow - Default to BundleCompatability.RESOLVE_BUNDLE when connectors are updating flows - Bug fixes; updated MockConnectorInitializationContext to extend from StandardConnectorInitializationContext to cut down on code duplication * NIFI-15467: Addressed review feedback
…desired state of Stateless Group Node before attempting to schedule; updated StandardProcessScheduler.startStatelessGroup to make it more clear if this is left out again at some point (apache#10832)
…; ensure that we synchronized Parmaeter Providers before Connectors (apache#10835)
apache#10833) * NIFI-15511: Added endpoints for purging all FlowFiles for a given Connector; added method to ConnectorClient to call these endpoints; updated system tests to use these endpoints when tearing down flows; some bug fixes * NIFI-15511: Added WRITE permission requirement for retrieving and deleting a Connector Purge request
apache#10815) * NIFI-15514: Ensure that Parameter Contexts are assigned to all Process Groups in a Connector and not just the top-level group. Ensure that all components are started when Connector starts instead of just Processors and Controller Services - When Working Context is recreated, ensure that we appropriately apply Parameter Context to newly created Process Group(s) - Ensure that when we cleanup unused assets for Connectors that we consider any assets that are referenced in either the Working or Active context instead of just the Active context - Ensure that when we stop Process Group we call all tasks in background threads instead of calling .thenRun which could potentially run in the foreground thread * NIFI-15514: Update parameter context assignment to occur during sync. * NIFI-15514: Fixes around ensuring that processors/controller services are properly configured and notified of any configuration changes when parameters change - Removed the updateParameterContexts from ProcessGroup.updateFlow, which was added in a previous commit as we went a different direction for the fix --------- Co-authored-by: Bob Paulin <bob@bobpaulin.com>
apache#10843) * NIFI-15538: When starting/stopping components allow specifying whether or not the action should be recursive; code cleanup and simplification to use a Virtual Thread to execute code sequentially instead of chaining CompletableFutures. * NIFI-15538: Addressed review feedback --------- Co-authored-by: Mark Payne <mark.payne@snowflake.com>
…ate (apache#10848) * NIFI-15480: Added ability to drop FlowFiles selectively using a Predicate Added system tests to verify selective dropping of flowfiles from a Connector. Also made significant updates so that diagnostic bundles are captured when a system test fails and diagnostic bundle also contains details of each Connection's FlowFileQueue. This was necessary in aiding the debugging of the new feature but is also something that has been missing for some time. * NIFI-15480: Ensure that when we perform a selective drop on a FlowFileQueue that we pass appropriate SWAP_FILE_DELETED / SWAP_FILE_RENAMED events to the FlowFile Repository
apache#10855) * NIFI-15549: Adding endpoints for viewing and clearing state for components that are managed by a Connector. * NIFI-15549: Addressing review feedback.
…rridden property values (apache#10862)
… some info/error for connector-related events (apache#10803)
… that are unavailable, make Connector invalid but not ghosted (apache#10851)
apache#10846) * NIFI-15539: Updating the actions in FlowFileQueueResource to support interacting with queues in flows managed by a Connector. * NIFI-15539: Updating resource endpoint to include data policies for connectors.
apache#10869) * NIFI-15565: Code cleanup; improvements to .cursorrules to provide better instructions regarding automated tests * NIFI-15565: Broke apart cursorrules file into the new format of .cursor/rules/*
* NIFI-15255 Introduce ConnectorConfigurationRepository Extension Interface * Add new property key to default nifi.properties file * Address peer review comments
…0883) * NIFI-15577: Including connector id in provenance event dto. - Fixing go to routing logic in the provenance event table. * NIFI-15577: Fixing back navigation context when navigating to provenance from the flow designer. This closes apache#10883
…roup node, do not synchronize parameter contexts if group is within a Connector (apache#10884)
…or, skip references from properties with unsatisfied dependencies
pvillard31
force-pushed
the
NIFI-15258
branch
from
b1858b4 to
f61609d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…or, skip references from properties with unsatisfied dependencies
Summary
NIFI-00000
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000VerifiedstatusPull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
./mvnw clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation