NIFI-16155 Apply autoResumeState to scheduling of controller services… - #11488
Merged
Conversation
exceptionfactory
left a comment
exceptionfactory
left a comment
Contributor
There was a problem hiding this comment.
Thanks for proposing this improvement @bbende. The functional changes look good. I noted a few minor comments on the new integration test class.
|
|
||
| import static org.junit.jupiter.api.Assertions.assertNotEquals; | ||
|
|
||
| public class AutoResumeStateControllerServiceIT extends NiFiSystemIT { |
Contributor
There was a problem hiding this comment.
The public modifiers can be removed
| public void testRootControllerServiceNotResumedWhenAutoResumeDisabled() throws NiFiClientException, IOException, InterruptedException { | ||
| final ControllerServiceEntity service = getClientUtil().createRootLevelControllerService("StandardCountService"); | ||
| getClientUtil().enableControllerService(service); | ||
| getClientUtil().waitForControllerServiceRunStatus(service.getId(), "ENABLED"); |
Contributor
There was a problem hiding this comment.
The ENABLED string could be declared once and reused
| } | ||
|
|
||
| private void restartWithAutoResumeStateDisabled() throws IOException, InterruptedException { | ||
| Thread.sleep(3000); |
Contributor
There was a problem hiding this comment.
This sleep could be brittle, is there any kind of status that could be polled instead, or is the sleep even needed before stopping?
Contributor
Author
|
Thanks @exceptionfactory , addressed the comments |
exceptionfactory
approved these changes
Jul 29, 2026
exceptionfactory
left a comment
exceptionfactory
left a comment
Contributor
There was a problem hiding this comment.
Thanks @bbende, the latest version looks good pending the workflow build completion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… during start-up
Summary
NIFI-16155
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000VerifiedstatusPull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
./mvnw clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation