NIFI-16172 - Fix: Multiple nifiTooltip hover tooltips can remain open at once and can get stuck open indefinitely - #11511
Merged
Merged
Conversation
… at once and can get stuck open indefinitely
Contributor
|
Reviewing... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-16172
Fixes the shared
nifiTooltiphover directive so at most one tooltip is visible, stuck-open tooltips self-heal when overlay mouseleave is dropped, and delayed open does not fire after a quick pass-through. Also enables delayed close on comment / validation-error tips in listing tables so users can move onto long scrollable tooltip content.Problem
Hovering the “more details” icon column (comments, validation errors, bulletins) in listing tables could leave multiple tooltips open at once. In some cases a tooltip stayed visible indefinitely after the pointer left, until another tip opened or the view was destroyed.
Separately, comment and validation-error tips used
[delayClose]="false", so long scrollable tooltips closed as soon as the pointer left the trigger and could not be scrolled. Bulletin tips already used delayed close.Most noticeable on Controller Services, Reporting Tasks, Parameter Providers, Connectors, Controller Service references, Manage Remote Ports, and Flow Analysis Rules.
Changes
Directive (
nifi-tooltip.directive.ts):openInstance; attaching a new tip detaches the previous one:hoveron trigger and tip instead of a sticky cached hover flagTemplates: set
[delayClose]="true"on comment / validation-error (and related) tips in the listing tables above so behavior matches bulletins and scrollable content remains reachable.Tests: Vitest coverage for the directive (9 tests), including single-active coordination, keep-open while hovering the tip, self-heal when tip mouseleave is dropped, cancel pending open, and no-open after delay when the trigger is no longer hovered. Spec
afterEachresets the staticopenInstance.Testing
npx nx test shared --testFile=nifi-tooltip.directive.spec.ts