Skip to content

NIFI-16181 Make MockProcessSession#commitAsync null safe - #11524

Merged
exceptionfactory merged 1 commit into
apache:mainfrom
awelless:NIFI-16181
Aug 10, 2026
Merged

NIFI-16181 Make MockProcessSession#commitAsync null safe#11524
exceptionfactory merged 1 commit into
apache:mainfrom
awelless:NIFI-16181

Conversation

@awelless

Copy link
Copy Markdown
Contributor

Summary

NIFI-16181

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000
  • Pull request contains commits signed with a registered key indicating Verified status

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using ./mvnw clean install -P contrib-check
    • JDK 21
    • JDK 25

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

Co-authored-by: Cursor <cursoragent@cursor.com>

@exceptionfactory exceptionfactory left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for raising this issue @awelless.

On initial review, it looks like the onSuccess and onFailure inputs should use Objects.requireNonNull() to align with current behavior expectations

@exceptionfactory exceptionfactory left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On closer review, it looks like the other ProcessSession implementations allow null, so this approach aligns with that behavior

@exceptionfactory exceptionfactory left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for adjusting the MockProcessSession behavior to align with standard implementation @awelless, looks good.

@exceptionfactory
exceptionfactory merged commit 96737bb into apache:main Aug 10, 2026
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants