NIFI-16202 Switch Mockito attachment to Java Agent - #11612
Merged
Conversation
- Moved argLine configuration from GitHub workflow to Maven properties
6 tasks
pvillard31
requested changes
Sep 2, 2026
| </excludes> | ||
| <redirectTestOutputToFile>true</redirectTestOutputToFile> | ||
| <!-- Runs Mockito as a Java Agent instead of relying on self-attachment --> | ||
| <argLine>@{argLine} ${surefire.opts} -javaagent:"${org.mockito:mockito-core:jar}"</argLine> |
Contributor
There was a problem hiding this comment.
Can we also configure the Mockito Java agent for maven-failsafe-plugin? The integration-test workflow still reports Mockito self-attachment warnings for tests run by Failsafe.
Contributor
Author
There was a problem hiding this comment.
Thanks @pvillard31, I pushed an update adding the configuration for the failsafe-plugin
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-16202 Changes the Mockito attachement strategy to use the explicit Java Agent approach instead of the default self-attachment, which results in warnings when building.
The changes adjust the GitHub build workflow, removing the
argLineSystem Property and instead wiring theSUREFIRE_OPTSenvironment variable through late property resolution in the Maven Surefire Plugin configuration. Together with a build profile that is activated on the presence ofSUREFIRE_OPTS, this approach ensures the wiring of additional Locale-specific environment variables to exercise behavior specific to different languages and regions.Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000VerifiedstatusPull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
./mvnw clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation