Skip to content

NIFI-5890 Added a unit test that proves that 1.9 fixes a bug in the d… - #3214

Closed
MikeThomsen wants to merge 1 commit into
apache:masterfrom
MikeThomsen:NIFI-5890
Closed

NIFI-5890 Added a unit test that proves that 1.9 fixes a bug in the d…#3214
MikeThomsen wants to merge 1 commit into
apache:masterfrom
MikeThomsen:NIFI-5890

Conversation

@MikeThomsen

Copy link
Copy Markdown
Contributor

…ate conversion behavior in 1.8.

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

@ijokarumawak ijokarumawak left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @MikeThomsen I confirmed that the added test case fails with NIFI 1.8.0 but passes with 1.9.0 snapshot. I am going to merge this PR without the change to PutElasticsearchHttpRecord as it should be a mistake. Thanks!

}
errorReason = reason;
logger.error("Failed to process {} due to {}, transferring to failure",
ta logger.error("Failed to process {} due to {}, transferring to failure",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this change is not intentional.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, definitely not. Thanks!

@asfgit asfgit closed this in 13a7f16 Dec 12, 2018
@MikeThomsen
MikeThomsen deleted the NIFI-5890 branch December 12, 2018 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants