Skip to content

NIFI-6759: When encountering Exception during load-balanced connectio…#3800

Closed
markap14 wants to merge 1 commit into
apache:masterfrom
markap14:NIFI-6759
Closed

NIFI-6759: When encountering Exception during load-balanced connectio…#3800
markap14 wants to merge 1 commit into
apache:masterfrom
markap14:NIFI-6759

Conversation

@markap14

@markap14 markap14 commented Oct 9, 2019

Copy link
Copy Markdown
Contributor

…n communications, after closing socket, return from method rather than continuing loop

Thank you for submitting a contribution to Apache NiFi.

Please provide a short description of the PR here:

Description of PR

Enables X functionality; fixes bug NIFI-YYYY.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • Have you verified that the full build is successful on both JDK 8 and JDK 11?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

…n communications, after closing socket, return from method rather than continuing loop

@phrocker phrocker left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually saw this when I was pushing data into my warehouse. This change LGTM. Glad to see it was fixed. Thanks!

@asfgit asfgit closed this in 5414cd5 Oct 9, 2019
@joewitt

joewitt commented Oct 10, 2019

Copy link
Copy Markdown
Contributor

@phrocker can you please make sure to sign the commits when you merge them. Makes it easier when seeing the log who reviewed and/or did the actual merge. Ideally the signature is also associated with a key as described in here http://nifi.apache.org/gpg.html

@phrocker

phrocker commented Oct 10, 2019

Copy link
Copy Markdown
Contributor

@joewitt I don't recall merging this -- unless I accidentally hit the merge button ( versus using the CLI)... I assumed Mark did when I saw the E-mail.
I checked minifi cpp and saw that some of my signoffs were not signed due to merging from different VMs. Thanks for the note as it shows I need to be more mindful of that.

@joewitt

joewitt commented Oct 10, 2019

Copy link
Copy Markdown
Contributor

Ah you must be right that Mark did. My bad.

patricker pushed a commit to patricker/nifi that referenced this pull request Jan 22, 2020
…n communications, after closing socket, return from method rather than continuing loop

This closes apache#3800.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants