Skip to content

NIFI-8410: Enabling TLS in RedisStateProvider - #4990

Closed
gresockj wants to merge 2 commits into
apache:mainfrom
gresockj:NIFI-8410
Closed

NIFI-8410: Enabling TLS in RedisStateProvider#4990
gresockj wants to merge 2 commits into
apache:mainfrom
gresockj:NIFI-8410

Conversation

@gresockj

Copy link
Copy Markdown
Contributor

Description of PR

This adds a property "Enable TLS" to the RedisStateProvider (see state-management.xml for further documentation). This allows a secured NiFi instance to use its own SSL context in the Redis connection provided by the RedisStateProvider. If set to "false" (the default), an insecure Redis connection will be used, regardless of whether the NiFi instance is TLS-enabled itself. If this property is set to "true" on an insecure NiFi instance, the state provider's validation will fail (since there is no SSL context to use), preventing the instance from starting up.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • Have you verified that the full build is successful on JDK 8?
  • Have you verified that the full build is successful on JDK 11?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.

@exceptionfactory exceptionfactory left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work on this @gresockj! I only found a small grammatical issue, the implementation looks good!

…ain/java/org/apache/nifi/redis/state/RedisStateProvider.java

Co-authored-by: exceptionfactory <exceptionfactory@apache.org>

@exceptionfactory exceptionfactory left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gresockj, looks good! +1 Merging.

@asfgit asfgit closed this in 2298953 Apr 12, 2021
krisztina-zsihovszki pushed a commit to krisztina-zsihovszki/nifi that referenced this pull request Jun 28, 2022
This closes apache#4990

Signed-off-by: David Handermann <exceptionfactory@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants