Skip to content

NIFI-9455 Add aggregated predictions to Prometheus#5582

Closed
timeabarna wants to merge 2 commits intoapache:mainfrom
timeabarna:NIFI-9455
Closed

NIFI-9455 Add aggregated predictions to Prometheus#5582
timeabarna wants to merge 2 commits intoapache:mainfrom
timeabarna:NIFI-9455

Conversation

@timeabarna
Copy link
Contributor

@timeabarna timeabarna commented Dec 8, 2021

https://issues.apache.org/jira/browse/NIFI-9455

Description of PR

Adding root level aggregated prediction metrics

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • Have you verified that the full build is successful on JDK 8?
  • Have you verified that the full build is successful on JDK 11?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.

Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvements @timeabarna! The filtering parameters are similar to the current PR #5571. Could you take a look at that PR and consider how the changes here would align?

PR #5571 implements similar sample name filtering, and include includes a collector registry filter, it also leverages the existing CollectorRegistry.filteredMetricFamilySamples() method to select one or more sample names. I would like to incorporate those changes to improve filtering for the existing Prometheus producer output before introducing the new JSON producer output if possible, so it would be helpful to get your feedback on that PR before moving forward on this one.

@timeabarna
Copy link
Contributor Author

This PR is pending on #5673

@timeabarna timeabarna changed the title NIFI-9455 Add json output for Prometheus metrics with basic filtering… NIFI-9455 Add aggregated predictions to Prometheus Jan 19, 2022
@timeabarna timeabarna force-pushed the NIFI-9455 branch 2 times, most recently from 9522f24 to 7ec7ba0 Compare January 21, 2022 14:58
@timeabarna
Copy link
Contributor Author

Thanks @exceptionfactory for your help. This PR should be the final of the consolidated PRs, can you please help reviewing it?

Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this pull request and implementing the features @timeabarna. The implementation looks straightforward, just a few small notes regarding the potential for declaring and reusing some static variables.

@timeabarna
Copy link
Contributor Author

Thanks @exceptionfactory for your review, I've modified the code based on your recommendations.

Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the adjustments @timeabarna! The changes look good and work as expected at runtime. +1 Merging.

krisztina-zsihovszki pushed a commit to krisztina-zsihovszki/nifi that referenced this pull request Jun 28, 2022
This closes apache#5582

Signed-off-by: David Handermann <exceptionfactory@apache.org>
Lehel44 pushed a commit to Lehel44/nifi that referenced this pull request Jul 1, 2022
This closes apache#5582

Signed-off-by: David Handermann <exceptionfactory@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants