NIFI-9587 Add json output for Prometheus metrics#5673
Closed
timeabarna wants to merge 2 commits intoapache:mainfrom
Closed
NIFI-9587 Add json output for Prometheus metrics#5673timeabarna wants to merge 2 commits intoapache:mainfrom
timeabarna wants to merge 2 commits intoapache:mainfrom
Conversation
Contributor
Author
|
Hello @exceptionfactory , as this PR is building on your PR 5571 would you mind reviewing it? Thanks in advance. |
13 tasks
Contributor
exceptionfactory
left a comment
There was a problem hiding this comment.
Thanks for putting together this feature @timeabarna! The implementation looks straightforward, and aligns well with the recently implemented filtering. I noted a couple minor questions, but otherwise it looks good.
...-framework/nifi-web/nifi-web-api/src/test/java/org/apache/nifi/web/api/TestFlowResource.java
Outdated
Show resolved
Hide resolved
...nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/FlowResource.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Thanks @exceptionfactory for the review. |
…urce, using ObjectMapper in TestFlowResource.
exceptionfactory
approved these changes
Jan 20, 2022
Contributor
exceptionfactory
left a comment
There was a problem hiding this comment.
Thanks for making the adjustments @timeabarna, looks good! +1 Merging.
krisztina-zsihovszki
pushed a commit
to krisztina-zsihovszki/nifi
that referenced
this pull request
Jun 28, 2022
This closes apache#5673 Signed-off-by: David Handermann <exceptionfactory@apache.org>
Lehel44
pushed a commit
to Lehel44/nifi
that referenced
this pull request
Jul 1, 2022
This closes apache#5673 Signed-off-by: David Handermann <exceptionfactory@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/NIFI-9587
Description of PR
Enables exposing Prometheus metrics in json
Enables basic filtering for Sample names and Sample values
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically
main)?Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not
squashor use--forcewhen pushing to allow for clean monitoring of changes.For code changes:
mvn -Pcontrib-check clean installat the rootnififolder?LICENSEfile, including the mainLICENSEfile undernifi-assembly?NOTICEfile, including the mainNOTICEfile found undernifi-assembly?.displayNamein addition to .name (programmatic access) for each of the new properties?For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.