Skip to content

NIFI-9587 Add json output for Prometheus metrics#5673

Closed
timeabarna wants to merge 2 commits intoapache:mainfrom
timeabarna:NIFI-9587
Closed

NIFI-9587 Add json output for Prometheus metrics#5673
timeabarna wants to merge 2 commits intoapache:mainfrom
timeabarna:NIFI-9587

Conversation

@timeabarna
Copy link
Contributor

@timeabarna timeabarna commented Jan 19, 2022

https://issues.apache.org/jira/browse/NIFI-9587

Description of PR

Enables exposing Prometheus metrics in json
Enables basic filtering for Sample names and Sample values

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • Have you verified that the full build is successful on JDK 8?
  • Have you verified that the full build is successful on JDK 11?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.

@timeabarna
Copy link
Contributor Author

Hello @exceptionfactory , as this PR is building on your PR 5571 would you mind reviewing it? Thanks in advance.

Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting together this feature @timeabarna! The implementation looks straightforward, and aligns well with the recently implemented filtering. I noted a couple minor questions, but otherwise it looks good.

@timeabarna
Copy link
Contributor Author

Thanks @exceptionfactory for the review.

…urce, using ObjectMapper in TestFlowResource.
Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the adjustments @timeabarna, looks good! +1 Merging.

krisztina-zsihovszki pushed a commit to krisztina-zsihovszki/nifi that referenced this pull request Jun 28, 2022
This closes apache#5673

Signed-off-by: David Handermann <exceptionfactory@apache.org>
Lehel44 pushed a commit to Lehel44/nifi that referenced this pull request Jul 1, 2022
This closes apache#5673

Signed-off-by: David Handermann <exceptionfactory@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants