NIFI-10075 Improve TestListSFTP configuration verification - #6092
Closed
exceptionfactory wants to merge 1 commit into
Closed
NIFI-10075 Improve TestListSFTP configuration verification#6092exceptionfactory wants to merge 1 commit into
exceptionfactory wants to merge 1 commit into
Conversation
- Changed assertVerificationSuccess() to separate testVerificationSuccessful() method - Upgraded TestListSFTP to JUnit 5
pvillard31
approved these changes
Jun 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-10075 Improves the behavior of
TestListSFTPto reduce the possibility of intermittent failures. TheassertVerificationSuccess()method previously ran before each test method, attempting to verify server connectivity multiple times. Changing the private method to a regular test method checks runs the check once, minimizing potential issues and allowing thestartServermethod to complete before running. Additional changes include upgrading the test to JUnit 5 and removing unnecessary exception declarations.Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation