Skip to content

Comments

NIFI-10240: remove custom validation check on protocol and SSL Contex…#6441

Closed
emiliosetiadarma wants to merge 1 commit intoapache:mainfrom
emiliosetiadarma:NIFI-10240
Closed

NIFI-10240: remove custom validation check on protocol and SSL Contex…#6441
emiliosetiadarma wants to merge 1 commit intoapache:mainfrom
emiliosetiadarma:NIFI-10240

Conversation

@emiliosetiadarma
Copy link
Contributor

…t Service, and made sure to check TCP is protocol set before using SSL Context Service during runtime

Summary

NIFI-10240

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 8
    • JDK 11
    • JDK 17

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

…t Service, and made sure to check TCP is protocol set before using SSL Context Service during runtime
Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvement @emiliosetiadarma! Based on previous pull requests and discussions, this makes sense as the best approach for now. +1 merging

p-kimberley pushed a commit to p-kimberley/nifi that referenced this pull request Oct 15, 2022
…nSyslog

- Made sure to check TCP is protocol set before using SSL Context Service during runtime

This closes apache#6441

Signed-off-by: David Handermann <exceptionfactory@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants