NIFI-10882 prevent setting of both BASIC and API_KEY Authorization Scheme properties in ElasticSearchClientService#6722
NIFI-10882 prevent setting of both BASIC and API_KEY Authorization Scheme properties in ElasticSearchClientService#6722ChrisSamo632 wants to merge 2 commits intoapache:mainfrom
Conversation
exceptionfactory
left a comment
There was a problem hiding this comment.
Thanks for working on this issue @ChrisSamo632! This sounds similar to an issue with ListenSyslog and SSL Context Service, resolved in PR #6441.
This issue is slightly complicated by the handling of dependent properties in the framework and the UI. Based on the approach for ListenSyslog, however, the better solution seems to be setting the appropriate Authorization header based on the selected Authorization Scheme. That avoids the situation where the component is invalid, but the properties that need to be removed are not visible to the user.
…heme properties in ElasticSearchClientService
…s based on selected AuthorizationScheme
20b1e60 to
2bd2390
Compare
Yeah, I umm'd and ah'd a bit about which of the approaches to take, then decided I'd opt for replicating what was originally done for NIFI-10760 in #6619 (removed for NIFI-10776 in #6662, but flagged as a non-blocking issue during the 1.19.0 release vote). Figured raising a PR would cause the discussion to decide which way to go. Another alternative would be for hidden properties to be reset to their default values (at the NiFi Framework level), but that seems like it should be a separate ticket with more considered discussion. All that said... I've pushed the changes to remove the new |
exceptionfactory
left a comment
There was a problem hiding this comment.
Thanks for giving it some thought and making the adjustments @ChrisSamo632, the updated approach looks good. +1 merging
…thorizationScheme This closes #6722 Signed-off-by: David Handermann <exceptionfactory@apache.org>
…thorizationScheme This closes apache#6722 Signed-off-by: David Handermann <exceptionfactory@apache.org>
Summary
NIFI-10882 prevent setting of both BASIC and API_KEY Authorization Scheme properties in ElasticSearchClientService
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-checkLicensing
[ ] New dependencies are compatible with the Apache License 2.0 according to the License Policy[ ] New dependencies are documented in applicableLICENSEandNOTICEfilesDocumentation
[ ] Documentation formatting appears as expected in rendered files