Skip to content

NIFI-11921: populate system load average in HB - #7584

Closed
KalmanJantner wants to merge 1 commit into
apache:mainfrom
KalmanJantner:NIFI-11921-populate-system-load-average
Closed

NIFI-11921: populate system load average in HB#7584
KalmanJantner wants to merge 1 commit into
apache:mainfrom
KalmanJantner:NIFI-11921-populate-system-load-average

Conversation

@KalmanJantner

@KalmanJantner KalmanJantner commented Aug 8, 2023

Copy link
Copy Markdown
Contributor

Summary

NIFI-11921

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 17

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

@exceptionfactory exceptionfactory left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @KalmanJantner! Does this change effectively deprecate the cpuUtilization property, or is that set somewhere else? If it is not longer set, then that should be noted in the API property annotation details.

@KalmanJantner

Copy link
Copy Markdown
Contributor Author

Thanks for the contribution @KalmanJantner! Does this change effectively deprecate the cpuUtilization property, or is that set somewhere else? If it is not longer set, then that should be noted in the API property annotation details.

@exceptionfactory thank you for the quick feedback. We will keep the cpuUtilization as cpp agent able to provide such information. Only JVM not fully support getting CPU Utilization (https://www.oracle.com/java/technologies/faq-sun-packages.html) only SystemLoadAverage is supported. So this change is about to extend what kind of CPU related information we can provide via HB and populate as much as we can in a given agent on the given platform.

@exceptionfactory exceptionfactory left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the background explanation @KalmanJantner. Retaining the existing property and populating the new load average property makes sense under those circumstances. +1 merging

exceptionfactory pushed a commit that referenced this pull request Aug 9, 2023
This closes #7584

Signed-off-by: David Handermann <exceptionfactory@apache.org>
(cherry picked from commit f8d0d2f)
@KalmanJantner
KalmanJantner deleted the NIFI-11921-populate-system-load-average branch February 11, 2025 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants