NIFI-13544 Add property to set the size of the threadpool of pubsub p…#9405
NIFI-13544 Add property to set the size of the threadpool of pubsub p…#9405PACordonnier wants to merge 1 commit intoapache:mainfrom
Conversation
exceptionfactory
left a comment
There was a problem hiding this comment.
Thanks for proposing this improvement @PACordonnier.
Given the behavior described, having a defined thread pool size makes sense. Rather than making it configurable, or supporting the existing behavior, I recommend setting the fixed number based on the maximum number of concurrent tasks configured for the Processor. The Concurrent Tasks control how many framework threads can invoke the Processor simultaneously, and that should align reasonably to the number of threads for the Publisher. Starting with that also avoids introducing a new property. If we do proceed to introduce a new property, the default could be set to the number of detected runtime processors, instead of the auto value as the existing behavior seems undesirable across the board.
|
@PACordonnier @exceptionfactory - as we're closing out items for 2.0 release, I took the liberty of making an update on this PR and file #9454 to address the comments and align the thread pool size with the number of concurrent tasks. |
…ublish
Summary
NIFI-13544
The PR adds a setting to the PublishGCPPubSub processor limiting the number of threads to be used by the processor. By default (if empty) use the default behaviour of having (5 * Number of CPU) threads per processor.
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation