Skip to content

NIFI-13544 Align number of executors with concurrent tasks in PublishGCPubSub#9454

Merged
exceptionfactory merged 1 commit intoapache:mainfrom
pvillard31:pr9405
Oct 28, 2024
Merged

NIFI-13544 Align number of executors with concurrent tasks in PublishGCPubSub#9454
exceptionfactory merged 1 commit intoapache:mainfrom
pvillard31:pr9405

Conversation

@pvillard31
Copy link
Contributor

Summary

NIFI-13544 - Align number of executors with concurrent tasks in PublishGCPubSub

See #9405

Copy link
Contributor

@greyp9 greyp9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix @pvillard31.

Having a good test setup to exercise this processor (from working NIFI-13927), I gave it a try.

Interestingly, the processor default of 1 concurrent task also solved the hang observed in that JIRA, where using the former default of 5 and the old processor code caused the hang to happen.

Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for implementing this proposed solution @pvillard31, and thanks for verifying the behavior @greyp9, I agree this looks good. +1 merging

Thanks again to @PACordonnier for raising the initial issue!

@exceptionfactory exceptionfactory merged commit 0cad418 into apache:main Oct 28, 2024
@exceptionfactory exceptionfactory added the hacktoberfest-accepted Hacktoberfest Accepted label Oct 28, 2024
@fpierrick
Copy link

Hello @pvillard31, is it possible to report this fix on 1.28.1 version please?

@pvillard31
Copy link
Contributor Author

@fpierrick - NiFi 1.28.1 has already been released and there is no plan for a new 1.x release unless critical security fixes need to be delivered on the 1.x release line (see https://nifi.apache.org/download/). Your best options are either going to NiFi 2, or applying this change to the source code of 1.28.1 and build NiFi yourself.

Pierrotws pushed a commit to alliage-io/nifi that referenced this pull request Mar 19, 2025
…GCPubSub (apache#9454)

Co-authored-by: Paul-Adrien Cordonnier <pauladrien@adaltas.com>
Signed-off-by: David Handermann <exceptionfactory@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hacktoberfest-accepted Hacktoberfest Accepted

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants