nshlib/ifconfig: Add support for add/del a single IPv6 address #2166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: The `SIOCSIFADDR` and `SIOCDIFADDR` uses different params for `AF_INET` and `AF_INET6` (`struct ifreq` vs `struct in6_ifreq`) as defined by https://man7.org/linux/man-pages/man7/netdevice.7.html Signed-off-by: Zhe Weng <wengzhe@xiaomi.com>
Note: We're using similar error codes as Linux: ``` linux> sudo ifconfig eth0 inet6 add fc00::2/64 linux> sudo ifconfig eth0 inet6 del fc00::2/112 SIOCDIFADDR: Cannot assign requested address linux> sudo ifconfig eth0 inet6 del fc00::3/64 SIOCDIFADDR: Cannot assign requested address linux> sudo ifconfig eth0 inet6 add fc00::2/64 SIOCSIFADDR: File exists nuttx> ifconfig eth0 inet6 add fc00::2/64 nuttx> ifconfig eth0 inet6 del fc00::2/112 Failed to manage IPv6 address: Cannot assign requested address nuttx> ifconfig eth0 inet6 del fc00::3/112 Failed to manage IPv6 address: Cannot assign requested address nuttx> ifconfig eth0 inet6 add fc00::2/64 Failed to manage IPv6 address: File exists ``` Signed-off-by: Zhe Weng <wengzhe@xiaomi.com>
xiaoxiang781216
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Depends on apache/nuttx#11054
Patches included:
We're using similar syntaxes and error codes as Linux:
Impact
Add support for add/del a single IPv6 address when we have multiple.
Testing
Manually, CI