tools: Fix bitmap converter print syntax#3592
Merged
xiaoxiang781216 merged 2 commits intoJul 6, 2026
Merged
Conversation
Use Python 3 print function syntax so bitmap_converter.py can be parsed by current Python interpreters while preserving the existing usage message and exit path. Generated-by: OpenAI Codex Signed-off-by: Old-Ding <35417409+Old-Ding@users.noreply.github.com>
xiaoxiang781216
previously approved these changes
Jul 6, 2026
Contributor
|
@Old-Ding please fix: |
Run the bitmap converter through the Python formatter required by checkpatch so the Python 3 print syntax fix passes the project style checks. Signed-off-by: Old-Ding <35417409+Old-Ding@users.noreply.github.com>
Contributor
Author
|
Updated in b0434f2: ran isort with NuttX's setup.cfg and �lack on ools/bitmap_converter.py so the checkpatch formatting failure is addressed. Local checks now pass: �lack --check, isort --check-only, lake8, py_compile, and git diff --check. |
xiaoxiang781216
approved these changes
Jul 6, 2026
jerpelea
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
py_compile.compile('tools/bitmap_converter.py', doraise=True)succeedspython tools/bitmap_converter.pyprints the usage message and exits with code1git diff --checkgit ls-files --eol tools/bitmap_converter.pyI also checked for open duplicate PRs/issues mentioning
bitmap_converter.py,Missing parentheses,Python 3, andprint, and found no matches.The
py_compilecheck createdtools/__pycache__; I removed that generated directory before committing.