examples: xmlrpc: bound header value copy#3602
Merged
xiaoxiang781216 merged 1 commit intoJul 9, 2026
Merged
Conversation
xiaoxiang781216
approved these changes
Jul 6, 2026
acassis
approved these changes
Jul 7, 2026
Old-Ding
force-pushed
the
codex/xmlrpc-header-value-bound
branch
from
21e989e to
a77586f
Compare
xmlrpc_handler() stores HTTP header values in a CONFIG_XMLRPC_STRINGSIZE + 1 byte buffer, but it passed CONFIG_EXAMPLES_XMLRPC_BUFFERSIZE to xmlrpc_getheader(). With the defaults, that allows a 1024 byte copy into a 65 byte destination. Make xmlrpc_getheader() treat size as the destination capacity, reserve one byte for the terminator, and pass sizeof(value) from the caller. Signed-off-by: Old-Ding <ai.neo.ae86@gmail.com>
Old-Ding
force-pushed
the
codex/xmlrpc-header-value-bound
branch
from
a77586f to
fdbf9fd
Compare
cederom
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
xmlrpc_getheader()treat its size argument as the destination capacitysizeof(value)fromxmlrpc_handler()instead of the HTTP request buffer sizeWhy
xmlrpc_handler()storesContent-Lengthinvalue, which is sized asCONFIG_XMLRPC_STRINGSIZE + 1. The previous call passedCONFIG_EXAMPLES_XMLRPC_BUFFERSIZEtoxmlrpc_getheader(); with the defaults, that permits copying up to 1024 bytes into a 65 byte destination.The helper also wrote the terminator after allowing
i == size, so the capacity contract should reserve space for the NUL byte.Testing
git diff --check HEAD~1..HEADgit show --stat --check --format=fuller HEADgcc,clang, orccinstalled.