examples: wgetjson: check allocations before use#3606
Merged
xiaoxiang781216 merged 1 commit intoJul 9, 2026
Conversation
xiaoxiang781216
previously approved these changes
Jul 6, 2026
Contributor
|
@Old-Ding please fix: |
cederom
reviewed
Jul 6, 2026
3778619 to
1fcddcd
Compare
Several malloc() results in the wgetjson example were used before checking for allocation failure, which could crash low-memory paths before cleanup ran. Return or propagate allocation errors before using the allocated buffers. Use explicit NULL comparisons for the new pointer checks to match review feedback. Signed-off-by: Old-Ding <ai.neo.ae86@gmail.com>
1fcddcd to
cf46b8b
Compare
cederom
approved these changes
Jul 8, 2026
xiaoxiang781216
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
Several
malloc()results in the wgetjson example were used immediately bymemcpy(),snprintf(),web_posts_str(),web_post_str(), orwebclient_perform()without first checking whether allocation succeeded. Low-memory paths could therefore crash before the existing cleanup logic ran.Testing
git diff --checkgit show --stat --check --format=fuller HEADNot run: local compile, because this environment does not have
make,cmake,gcc,clang, orccavailable.