system: nxinit: bound debug argv dump#3610
Merged
xiaoxiang781216 merged 1 commit intoJul 7, 2026
Merged
Conversation
Check the service argv array bound before reading the current entry in the debug dump loop. A full argument array may not have an in-array NULL terminator, so the old condition could read one entry past the array while CONFIG_SYSTEM_NXINIT_DEBUG is enabled. Signed-off-by: Old-Ding <35417409+Old-Ding@users.noreply.github.com>
xiaoxiang781216
approved these changes
Jul 6, 2026
cederom
approved these changes
Jul 6, 2026
Contributor
|
@xiaoxiang781216 the download of ameba SDK is failing with permission error 403, probably it requires password or some captcha |
linguini1
approved these changes
Jul 6, 2026
Contributor
|
@Old-Ding please update git commit signature to valid email address as in other pr series :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
init_dump_service()evaluateds->argv[i]before checkingi < nitems(s->argv). Service argument arrays are zero-initialized, but a full parsed argument list can fill the array without an in-array NULL terminator. WithCONFIG_SYSTEM_NXINIT_DEBUGenabled, the dump loop could then read one entry past the array.Testing
git diff --checkgit show --stat --check --format=fuller HEADBuild not run locally because this Windows machine does not have
make,cmake,gcc,clang, orccinstalled.