{bp-3598} !fsutils/passwd: remove insecure default TEA encryption keys#3612
Merged
Conversation
Use 0 as a Kconfig placeholder. The nuttx build rejects unset keys and can generate random values when configured. BREAKING CHANGE: CONFIG_FSUTILS_PASSWD_KEY1..4 no longer default to 0x12345678 / 0x9abcdef0. Configs that relied on those defaults must set keys manually or enable BOARD_ETC_ROMFS_PASSWD_RANDOMIZE_KEYS in nuttx. Fix: set keys in menuconfig or enable random key generation. Signed-off-by: Abhishek Mishra <mishra.abhishek2808@gmail.com>
jerpelea
requested review from
acassis,
cederom,
linguini1,
lupyuen and
xiaoxiang781216
xiaoxiang781216
approved these changes
Jul 6, 2026
cederom
approved these changes
Jul 6, 2026
Contributor
Author
|
@cederom ping |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use 0 as a Kconfig placeholder. The nuttx build rejects unset keys and can generate random values when configured.
BREAKING CHANGE: CONFIG_FSUTILS_PASSWD_KEY1..4 no longer default to 0x12345678 / 0x9abcdef0. Configs that relied on those defaults must set keys manually or enable BOARD_ETC_ROMFS_PASSWD_RANDOMIZE_KEYS in nuttx. Fix: set keys in menuconfig or enable random key generation.
Impact
RELEASE
Testing
CI