netutils/rexecd: forward PRIORITY/STACKSIZE config in CMake build - #3655
Merged
acassis merged 1 commit intoJul 23, 2026
Merged
Conversation
xiaoxiang781216
approved these changes
Jul 22, 2026
Contributor
|
please rebase to the last master which fix the ci error. @JianyuWang0623 |
The Makefile build already forwards both values via PRIORITY / STACKSIZE. Align the CMake build with the Makefile so that CONFIG_NETUTILS_REXECD_PRIORITY and CONFIG_NETUTILS_REXECD_STACKSIZE take effect under CMake as well. Assisted-by: GitHubCopilot:claude-4.8-opus Signed-off-by: wangjianyu3 <wangjianyu3@xiaomi.com>
JianyuWang0623
force-pushed
the
netutils-rexecd-cmake-config
branch
from
July 22, 2026 11:30
4ea1d13 to
cdf1f1a
Compare
acassis
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: Please adhere to Contributing Guidelines.
Summary
The Makefile build of
netutils/rexecdalready forwards the configuredtask priority and stack size via the
PRIORITY/STACKSIZEvariables,but the CMake build did not. As a result,
CONFIG_NETUTILS_REXECD_PRIORITYand
CONFIG_NETUTILS_REXECD_STACKSIZEhad no effect when building with CMake.This change updates
netutils/rexecd/CMakeLists.txtto passSTACKSIZE(
${CONFIG_NETUTILS_REXECD_STACKSIZE}) andPRIORITY(
${CONFIG_NETUTILS_REXECD_PRIORITY}) tonuttx_add_application(), aligningthe CMake build behavior with the existing Makefile build.
Impact
Testing
with the Makefile build.