system/readline: Fix small issues - #3669
Conversation
|
@xiaoxiang781216 maybe we could include this test suite in our CI (or ideally modify it to be included into NTFC) |
This PR fixes some small issues raised by Xiang Xiao. Signed-off-by: Alan C. Assis <acassis@gmail.com>
cederom
left a comment
There was a problem hiding this comment.
Thank you @acassis and @xiaoxiang781216 :-)
|
Argh sorry @xiaoxiang781216 I have re-requested review and that cleared your approval my apologies o_O |
@raiden00pl :-) |
|
Disabled the Lined Editing to TIVA Board : QEMU Protected because the board reports there is no free space: Building locally it says there are more than 60KB of free space. |
|
@acassis you can extend https://github.com/apache/nuttx-ntfc-testing/tree/main/arch/nsh but you need port these tests to ntfc/pytest format. This is a good idea, it's worth creating an issue about it |
Summary
This PR fixes some small issues raised by Xiang Xiao.
Impact
Improvement
Testing
Tested on nsh_readline_test_suite.py