Skip to content

system/readline: Fix small issues - #3669

Merged
acassis merged 1 commit into
apache:masterfrom
acassis:fix_nsh_cmdline
Jul 26, 2026
Merged

system/readline: Fix small issues#3669
acassis merged 1 commit into
apache:masterfrom
acassis:fix_nsh_cmdline

Conversation

@acassis

@acassis acassis commented Jul 26, 2026

Copy link
Copy Markdown
Contributor

Summary

This PR fixes some small issues raised by Xiang Xiao.

Impact

Improvement

Testing

Tested on nsh_readline_test_suite.py

##############################################################################
# RESULTS: 582/583 passed, 0 failed, 1 known limitation(s)
# (3 of the passes needed an isolated re-run to confirm -- see notes above; this is simulator I/O-scheduling flakiness under sustained load, not a readline defect)
##############################################################################
``

@acassis

acassis commented Jul 26, 2026

Copy link
Copy Markdown
Contributor Author

@xiaoxiang781216 maybe we could include this test suite in our CI (or ideally modify it to be included into NTFC)
nsh_readline_test_suite.py

This PR fixes some small issues raised by Xiang Xiao.

Signed-off-by: Alan C. Assis <acassis@gmail.com>

@cederom cederom left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @acassis and @xiaoxiang781216 :-)

@cederom
cederom requested a review from xiaoxiang781216 July 26, 2026 16:51
@cederom

cederom commented Jul 26, 2026

Copy link
Copy Markdown
Contributor

Argh sorry @xiaoxiang781216 I have re-requested review and that cleared your approval my apologies o_O

@cederom

cederom commented Jul 26, 2026

Copy link
Copy Markdown
Contributor

@acassis: @xiaoxiang781216 maybe we could include this test suite in our CI (or ideally modify it to be included into NTFC) nsh_readline_test_suite.py

@raiden00pl :-)

@acassis

acassis commented Jul 26, 2026

Copy link
Copy Markdown
Contributor Author

Disabled the Lined Editing to TIVA Board : QEMU Protected because the board reports there is no free space:

apache/nuttx#19546

Building locally it says there are more than 60KB of free space.

@acassis
acassis merged commit 8d5e9f3 into apache:master Jul 26, 2026
75 of 79 checks passed
@raiden00pl

Copy link
Copy Markdown
Member

@acassis you can extend https://github.com/apache/nuttx-ntfc-testing/tree/main/arch/nsh but you need port these tests to ntfc/pytest format. This is a good idea, it's worth creating an issue about it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants