-
Notifications
You must be signed in to change notification settings - Fork 1.4k
net/packet: add PACKET_<ADD|DROP>_MEMBERSHIP support #17551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
acassis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zhhyu7 please add a Documentation about it at https://nuttx.apache.org/docs/latest/components/net/index.html maybe more specifically here: https://nuttx.apache.org/docs/latest/components/net/netdriver.html or create a new entry to it if you think it doesn't fit in the existing categories.
OK, After https://github.com/apache/nuttx/pull/17483 PR is merged, I will add the new part based on the modifications of this PR. |
@acassis let's finish the document on the next patch? |
@xiaoxiang781216 from previous experience the Documentation never come later, if the PR adds a new feature, it needs to include a Documentation. We all agreed on that in the voting. Similar for testing, to avoid breaking the mainline with features that people forget to test |
acassis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zhhyu7 please add Documentation
Some third-party network libraries use PACKET_ADD_MEMBERSHIP to add MAC addresses to devices, and this patch can add support for this. Signed-off-by: zhanghongyu <zhanghongyu@xiaomi.com>
Avoid PACKET_ADD_MEMBERSHIP calls returning errors. Signed-off-by: zhanghongyu <zhanghongyu@xiaomi.com>
Summary
Some third-party network libraries use PACKET_ADD_MEMBERSHIP to add MAC addresses to devices, and this patch can add support for this.
Impact
net/pkt: setsockopt
Testing
sim:matter with below test code:
NuttX test log