drivers/sensors: update upper->parsebuffer every new line #17768
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"Sensor procfs - Dynamic sensor debugging tool\n" "\n" "Usage:\n" " cat /proc/sensor_monitor - Show currently monitored topics\n" " echo <level> <topic> > /proc/sensor_monitor - Add topic(s)\n" " echo rm <topic> > /proc/sensor_monitor - Remove topic(s)\n" " echo add <topic> <topic> > /proc/sensor_monitor" " - add/remove topics\n" " echo clean > /proc/sensor_monitor - Remove all topics\n" "\n" "Examples:\n" " echo sensor_accel > /proc/sensor_monitor\n" " echo \"sensor_accel sensor_compass\" > /proc/sensor_monitor\n" " echo \"1 sensor_accel sensor_compass\" > /proc/sensor_monitor\n" " echo \"2 sensor_accel sensor_compass\" > /proc/sensor_monitor\n" " echo \"rm sensor_accel\" > /proc/sensor_monitor\n" " echo \"rm sensor_accel sensor_compass\" > /proc/sensor_monitor\n" " echo clean > /proc/sensor_monitor\n" " echo \"add 1 sensor_a rm sensor_b\" > /proc/sensor_monitor\n" "\n" "Note:\n" " If <level> is not specified, it defaults to 1.\n"; Signed-off-by: chenzihan1 <chenzihan1@xiaomi.com>
When the last data sent by the driver does not contain \n\r, it will cause a GAA parsing error Signed-off-by: chenzihan1 <chenzihan1@xiaomi.com>
chenzihan0416
requested review from
Donny9,
acassis,
jerpelea,
linguini1,
raiden00pl,
simbit18 and
xiaoxiang781216
as code owners
github-actions
bot
added
Area: Sensors
Contributor
|
@chenzihan0416 why did you close it? Since like a good fix |
linguini1
reviewed
Jan 5, 2026
| { | ||
| if (*buffer == '$') | ||
| { | ||
| upper->parsenext = 0; |
Contributor
There was a problem hiding this comment.
Good fix! Isn't this the only required line for this bug fix? I think the sensor monitor stuff is accidentally mixed in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix GNSS NMEA parser buffer overflow handling by resetting parse position after error.
When the NMEA parser detects a buffer overflow (line exceeds
GNSS_PARSE_BUFFERSIZE), it logs an error message but fails to resetparsenextto 0. This causes subsequent NMEA sentences to be appended to the corrupted buffer, leading to:Impact
Testing
before fix:
after fix: