arch/arm/src/stm32h5/stm32_usbdrdhost.c: Fixed Hub support#18761
Merged
xiaoxiang781216 merged 1 commit intoapache:masterfrom Apr 19, 2026
Merged
arch/arm/src/stm32h5/stm32_usbdrdhost.c: Fixed Hub support#18761xiaoxiang781216 merged 1 commit intoapache:masterfrom
xiaoxiang781216 merged 1 commit intoapache:masterfrom
Conversation
Fixed a few bugs in the initial stm32_usbdrdhost.c implementation when using a USB hub. Fixed fault when freeing control endpoints. Fixed crash when disconnecting devices from hubs due ot use after free. Signed-off-by: daniellizewski <daniellizewski@geotab.com>
acassis
approved these changes
Apr 18, 2026
xiaoxiang781216
approved these changes
Apr 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed a few bugs in the initial stm32_usbdrdhost.c implementation when using a USB hub. Fixed fault when freeing control endpoints. Fixed crash when disconnecting devices from hubs due ot use after free.
Note: Please adhere to Contributing Guidelines.
Summary
In the initial STM32H5 USB host support I forgot to test devices with a USB hub.
A few changes were needed to get USB hub working.
Added missing hub specific calls and fixed freeing control endpoints that were allocated through the hub.
I also fixed a crash when disconnecting a device from a hub becasue connport->devclass->connect was
already set to NULL after CLASS_DISCONNECTED
Impact
Only adds new features.
Testing
Logs of the above are attached:
stm32h5_usb_with_hub.txt