fs/vfs/fs_lock.c: Close stale locks unconditionally#18811
Merged
xiaoxiang781216 merged 1 commit intoapache:masterfrom Apr 28, 2026
Merged
fs/vfs/fs_lock.c: Close stale locks unconditionally#18811xiaoxiang781216 merged 1 commit intoapache:masterfrom
xiaoxiang781216 merged 1 commit intoapache:masterfrom
Conversation
Allow to close the lock even the dying task is in signal handler context. Also the file type check can be ignored as they are already validated in create phase. Signed-off-by: Jari Nippula <jari.nippula@tii.ae>
github-actions
Bot
added
Area: File System
acassis
approved these changes
Apr 28, 2026
Contributor
|
@jnippula maybe more testing is needed to avoid some side effects in others applications |
xiaoxiang781216
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allow to close the lock even the dying task is in signal handler context (e.g. kill).
Impact
This patch prevents file locks to stay locked/acquired by already killed task,
so the file can be locked by new task if the previous owner has been
killed.
Testing
Build target: RISC-V mpfs based custom hardware.
Test sequence:
kill 2790)Without this patch the file lock is still acquired by the task that
is already killed and not visible in task list anymore. New task
can't acquire the file lock anymore:
With this patch the file lock is released when the owner task is killed
and new task can acquire the file lock properly.