Skip to content

{bp-19280} arch/[risc-v|xtensa]: update Espressif's common source code#19283

Merged
xiaoxiang781216 merged 4 commits into
apache:releases/13.0from
jerpelea:bp-19280
Jul 3, 2026
Merged

{bp-19280} arch/[risc-v|xtensa]: update Espressif's common source code#19283
xiaoxiang781216 merged 4 commits into
apache:releases/13.0from
jerpelea:bp-19280

Conversation

@jerpelea

@jerpelea jerpelea commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Summary

arch/[risc-v|xtensa]: update Espressif's common source code

Updates Espressif's common source code to ensure that critical sections are properly handled by the common source code.

includes
#19009

Impact

RELEASE

Testing

CI

eren-terzioglu and others added 4 commits July 3, 2026 09:14
@eren-terzioglu @jerpelea
arch/risc-v/espressif: Add BLE support for esp32[-c6|-h2]
bab9888 
Add BLE support for esp32c6 and esp32h2

Signed-off-by: Eren Terzioglu <eren.terzioglu@espressif.com>
@eren-terzioglu @jerpelea
boards/risc-v/espressif: Add BLE board support for esp32[-c6|-h2]
68812c3 
Add BLE board support for esp32c6 and esp32h2

Signed-off-by: Eren Terzioglu <eren.terzioglu@espressif.com>
@eren-terzioglu @jerpelea
Docs/platforms/esp32[-c6|-h2]: Add BLE docs for esp32[-c6|-h2]
abe3afd 
Add BLE docs for esp32c6 and esp32h2

Signed-off-by: Eren Terzioglu <eren.terzioglu@espressif.com>
@tmedicci @jerpelea
arch/[risc-v|xtensa]: update Espressif's common source code
45c49d1 
This commit updates Espressif's common source code to ensure that
critical sections are properly handled by the common source code.

Signed-off-by: Tiago Medicci Serrano <tiago.medicci@espressif.com>
@github-actions github-actions Bot added Area: Documentation Improvements or additions to documentation Arch: risc-v Issues related to the RISC-V (32-bit or 64-bit) architecture Arch: xtensa Issues related to the Xtensa architecture Size: XL The size of the change in this PR is very large. Consider breaking down the PR into smaller pieces. Board: risc-v labels Jul 3, 2026
@jerpelea

jerpelea commented Jul 3, 2026

Copy link
Copy Markdown
Contributor Author

@eren-terzioglu
riscv-none-elf-ld: /github/workspace/sources/nuttx/nuttx section .text' will not fit in region ilm'
riscv-none-elf-ld: region `ilm' overflowed by 976 bytes

are you aware?

@eren-terzioglu

eren-terzioglu commented Jul 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

@eren-terzioglu riscv-none-elf-ld: /github/workspace/sources/nuttx/nuttx section .text' will not fit in region ilm' riscv-none-elf-ld: region `ilm' overflowed by 976 bytes

are you aware?

That's interesting. It did not appear when I implemented also internal CI did not show anything like that. Probably something was missing which merged earlier than BLE support

@jerpelea

jerpelea commented Jul 3, 2026

Copy link
Copy Markdown
Contributor Author

can you test locally?

@eren-terzioglu

eren-terzioglu commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

can you test locally?

I can check but it will be end of today (my local timezone is afternoon here). I will update you.

@jerpelea

jerpelea commented Jul 3, 2026

Copy link
Copy Markdown
Contributor Author

tks. seems to be the last issue before I'll tag RC1

@eren-terzioglu

eren-terzioglu commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

tks. seems to be the last issue before I'll tag RC1

BTW are you sure it is related to Espressif products? Seems it is related to this defconfig, right?

2026-07-03T09:58:04.6419842Z Configuration/Tool: hpm6360evk/nsh
2026-07-03T09:58:04.6500478Z 2026-07-03 09:58:04
2026-07-03T09:58:04.6500877Z ------------------------------------------------------------------------------------
2026-07-03T09:58:04.6501286Z   Cleaning...
2026-07-03T09:58:07.8084700Z   Configuring...
2026-07-03T09:58:11.8597558Z   Building NuttX...
2026-07-03T09:58:41.8594617Z riscv-none-elf-ld: /github/workspace/sources/nuttx/nuttx section `.text' will not fit in region `ilm'
2026-07-03T09:58:41.8621055Z riscv-none-elf-ld: region `ilm' overflowed by 976 bytes
2026-07-03T09:58:41.8981060Z make[1]: *** [Makefile:195: nuttx] Error 1
2026-07-03T09:58:41.8985633Z make: *** [tools/Unix.mk:569: nuttx] Error 2
2026-07-03T09:58:41.8986061Z make: Target 'all' not remade because of errors.

@jerpelea

jerpelea commented Jul 3, 2026

Copy link
Copy Markdown
Contributor Author

that board has no diff to master

@tmedicci

tmedicci commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

that board has no diff to master

Should we trigger the CI again, then? I can't see why this change would interfere with another board....

@tmedicci

tmedicci commented Jul 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Wait: https://github.com/apache/nuttx/pull/19280/changes only has a single commit. Something may have happened while creating the backport, @jerpelea

@jerpelea

jerpelea commented Jul 3, 2026

Copy link
Copy Markdown
Contributor Author

includes
#19009

@jerpelea

jerpelea commented Jul 3, 2026

Copy link
Copy Markdown
Contributor Author

the issue appears on all open risv-v ci builds

@eren-terzioglu

eren-terzioglu commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

@jerpelea, I checked out this branch and removed these 4 commits and made head this commit:

commit a0357b3a6537946d9d7e9a40ff3df405efe3af35 (HEAD -> bp-19280)
Author: Xiang Xiao <xiaoxiang@xiaomi.com>
Date:   Wed Jun 24 17:53:33 2026 +0800

    !include/fcntl.h: align open flags with Linux values
    
    Align the NuttX open(2) flag constants with the Linux asm-generic
    values so that the FUSE wire protocol and other cross-platform
    interfaces work without conversion.
    
    All code that used '(flags & O_RDONLY)' as a bitmask check (always 0
    now that O_RDONLY=0) has been updated to use '(flags & O_ACCMODE)'
    comparisons.
    
    The NUTTX_O_* constants in include/nuttx/fs/hostfs.h are updated to
    match, and the sim hostfs open flag mapping is fixed.
    
    Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>

This build steps applied:

make -j distclean
./tools/configure.sh hpm6360evk:nsh
make -j

And same error happened:

~/nuttxspace/nuttx$ make -j8
Create version.h
LN: platform/board to /home/eren/nuttxspace/apps/platform/dummy
Register: hello
Register: sh
Register: nsh
LD: nuttx
riscv-none-elf-ld: /home/eren/nuttxspace/nuttx/nuttx section `.text' will not fit in region `ilm'
riscv-none-elf-ld: region `ilm' overflowed by 968 bytes
Memory region         Used Size  Region Size  %age Used
             ilm:      132040 B       128 KB    100.74%
             dlm:       11360 B       128 KB      8.67%
        axi_sram:           0 B       256 KB      0.00%
axi_sram_noncacheable:           0 B       256 KB      0.00%
        ahb_sram:           0 B        32 KB      0.00%
make[1]: *** [Makefile:195: nuttx] Error 1
make: *** [tools/Unix.mk:569: nuttx] Error 2

Seems error is unrelated these commits.

When I bisect it (between releases/13.0 to master) this commit is first build error:

commit 361e7e29ae7f6ae6492c21b0d4a1339224d41247
Author: Jukka Laitinen <jukka.laitinen@tii.ae>
Date:   Wed Jun 10 11:14:26 2026 +0300

    arch, sched/signal: Fix compilation with ENABLE_PARTIAL_SIGNALS=y
    
    Correct build errors when CONFIG_ENABLE_ALL_SIGNALS is not defined
    
    - sched makefiles: Move pending-signal helpers from the ENABLE_ALL_SIGNALS-only
      list to the !DISABLE_ALL_SIGNALS list so signal dispatch is available in
      PARTIAL builds sched: make SIG_PREALLOC_ACTIONS, SIG_ALLOC_ACTIONS and
      SIG_DEFAULT depend on ENABLE_ALL_SIGNALS
    - sched: fix ifdefs around pending-signal queue access and signal-mask for
      PARTIAL/DISABLE modes
    - arch: gate SYS_signal_handler / _return calls and SYSCALL_LOOKUP(signal)
      with ENABLE_ALL_SIGNALS
    
    Signed-off-by: Jukka Laitinen <jukka.laitinen@tii.ae>

NX branch: jerpelea:bp-19280 (without last 4 commits)
Apps branch: commit 5bf9b4ea9ac9facafa0ca10f3f95f0098a17db77 (HEAD -> releases/13.0, origin/releases/13.0)

@xiaoxiang781216 xiaoxiang781216 merged commit fd3889c into apache:releases/13.0 Jul 3, 2026
41 of 80 checks passed
@jerpelea

jerpelea commented Jul 4, 2026

Copy link
Copy Markdown
Contributor Author

@eren-terzioglu thanks for the updates
I will proceed with the fix and release

@jerpelea jerpelea deleted the bp-19280 branch July 4, 2026 11:53
@jerpelea jerpelea mentioned this pull request Jul 4, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xiaoxiang781216 xiaoxiang781216 xiaoxiang781216 approved these changes
@eren-terzioglu eren-terzioglu eren-terzioglu approved these changes
@acassis acassis Awaiting requested review from acassis
@cederom cederom Awaiting requested review from cederom
@antmerlino antmerlino Awaiting requested review from antmerlino
@lupyuen lupyuen Awaiting requested review from lupyuen
@linguini1 linguini1 Awaiting requested review from linguini1
@tmedicci tmedicci Awaiting requested review from tmedicci tmedicci is a code owner
@fdcavalcanti fdcavalcanti Awaiting requested review from fdcavalcanti fdcavalcanti is a code owner

Assignees

No one assigned

Labels

Arch: risc-v Issues related to the RISC-V (32-bit or 64-bit) architecture Arch: xtensa Issues related to the Xtensa architecture Area: Documentation Improvements or additions to documentation Board: risc-v Size: XL The size of the change in this PR is very large. Consider breaking down the PR into smaller pieces.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jerpelea @eren-terzioglu @tmedicci @xiaoxiang781216