tools: rp2040: Drop uninitialized name length check#19320
Merged
xiaoxiang781216 merged 1 commit intoJul 10, 2026
Conversation
Old-Ding
requested review from
gustavonihei,
jerpelea and
pkarashchenko
as code owners
github-actions
Bot
added
Area: Tooling
Size: XS
|
scan_dir() checked name_len before assigning it. Directory entries already compute and validate strlen(a_dirent->d_name) before allocating the dir item, while the root path passed to scan_dir() is not encoded as a directory entry name. Remove the stale pre-opendir check so scan_dir() no longer branches on an uninitialized local variable. Generated-by: OpenAI Codex Signed-off-by: aineoae86-sys <ai.neo.ae86@gmail.com>
Old-Ding
force-pushed
the
codex/rp2040-flashfs-name-len
branch
from
3aecd4a to
80acd00
Compare
xiaoxiang781216
approved these changes
Jul 6, 2026
jerpelea
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
opendir()name_lencheck inscan_dir()a_dirent->d_nameis availableWhy
scan_dir()checkedname_lenbefore assigning it. That means the tool can branch on an uninitialized local variable before opening the directory. The actual filesystem entry names are already measured and checked afterreaddir()returns each regular file or directory.Testing
git diff --check origin/master..HEADgit show --check --stat --oneline HEADgcc/clang/makeor WSL/bash shell