drivers: pci: fix EPC MSI IRQ map validation#19324
Merged
Merged
Conversation
pci_epc_map_msi_irq() used && when checking the EPC pointer and map_msi_irq callback. If epc is NULL, the right-hand side dereferences it; if the callback is NULL on a valid EPC, the guard does not reject it before the call. Match the surrounding EPC wrappers by rejecting a NULL EPC, an out-of-range function number, or a missing map_msi_irq callback before taking the lock and invoking the operation. Generated-by: OpenAI Codex Signed-off-by: Old-Ding <35417409+Old-Ding@users.noreply.github.com>
github-actions
Bot
added
Size: XS
|
xiaoxiang781216
approved these changes
Jul 6, 2026
jerpelea
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pci_epc_map_msi_irq()to reject a NULL EPC or missingmap_msi_irqcallbackWhy
pci_epc_map_msi_irq()currently uses&&between the EPC NULL check and the callback check. That dereferencesepcwhen it is NULL, and it lets a valid EPC with nomap_msi_irqcallback pass through to a NULL function call.The surrounding EPC wrappers also validate
funcnobefore dispatching to controller operations, so this helper now follows the same input-validation pattern.Testing
git diff --check origin/master...HEADgit show --stat --check --format=fuller HEAD