arch/arm: nrf91: bound modem version parsing#19328
Merged
Merged
Conversation
Limit modem version tokens parsed from AT command responses to the LTE version field sizes. Also require both HWVERSION fields before copying them so a partial parse does not read an uninitialized temporary buffer. Signed-off-by: Old-Ding <35417409+Old-Ding@users.noreply.github.com>
github-actions
Bot
added
Arch: arm
|
xiaoxiang781216
approved these changes
Jul 6, 2026
jerpelea
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AT%HWVERSIONfields before copying themRoot cause
nrf_modem_at_scanf()was using unbounded%sconversions into 16-byte temporary buffers even though the LTE version fields can hold 32 bytes. The two-fieldAT%HWVERSIONparse also copied both buffers when only one field was parsed, which could read an uninitialized temporary buffer.Testing
git diff --checkgit show --stat --check --format=fuller HEADBuild not run locally because this Windows machine does not have
make,cmake,gcc,clang, orccinstalled.