libc/stream: Check lowout bounds before access#19329
Merged
Merged
Conversation
Check the provided length before reading the current lowoutstream byte. This avoids reading past zero-length or fully consumed buffers before the loop condition stops. Generated-by: OpenAI Codex Signed-off-by: Old-Ding <35417409+Old-Ding@users.noreply.github.com>
github-actions
Bot
added
Area: OS Components
|
xiaoxiang781216
approved these changes
Jul 6, 2026
jerpelea
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n- check the output length before reading the current byte in lowoutstream_puts()\n- avoid reading str[0] for zero-length writes or str[len] after the buffer is consumed\n\n## Verification\n- git diff --check HEAD^ HEAD -- libs/libc/stream/lib_lowoutstream.c\n- git show --stat --check --format=fuller HEAD\n- git ls-files --eol -- libs/libc/stream/lib_lowoutstream.c