arch: imx9: allow last CCM root index#19336
Merged
xiaoxiang781216 merged 1 commit intoJul 6, 2026
Merged
Conversation
CCM_CR_COUNT is defined as the last CCM root index in the non-SCMI tables, and CCM_CR_PALCAMESCAN also uses that value. Use a strict greater-than check so root 94 reaches the CCM register helpers. Generated-by: OpenAI Codex Signed-off-by: Old-Ding <35417409+Old-Ding@users.noreply.github.com>
github-actions
Bot
added
Arch: arm
|
xiaoxiang781216
approved these changes
Jul 6, 2026
acassis
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
CCM_CR_COUNTis defined as 94 in the non-SCMI CCM headers, andCCM_CR_PALCAMESCANis also 94. Theg_ccm_root_muxtables contain 95 entries, so root 94 is a valid table/register index. Theroot >= CCM_CR_COUNTchecks rejected that last valid root before reaching the CCM helpers.Testing
git diff --check HEAD~1 HEADgit show --stat --check --format=fuller HEADCCM_CR_COUNT=94,CCM_CR_PALCAMESCAN=94,MuxEntries=95Not run locally:
tools/checkpatch.sh -f arch/arm/src/imx9/imx9_ccm.c arch/arm64/src/imx9/imx9_ccm.c(localbashopens the Windows WSL install prompt)make,gcc,arm-none-eabi-gcc, andclangare not installed)