{bp-19307} drivers/audio/i2s: Fix unsigned integers in function signatures#19340
Merged
Conversation
All I2S driver operation functions say in their signature description that negative errno values are returned on failure. However, some of these same functions had `uint32_t` return types. This would result in incorrect comparison of the return value against signed error code values. Signed-off-by: Matteo Golin <matteo.golin@gmail.com>
jerpelea
requested review from
Ouss4,
acassis,
adamfeuer,
antmerlino,
eren-terzioglu,
fdcavalcanti,
masayuki2009,
michallenc,
pkarashchenko and
tmedicci
as code owners
github-actions
Bot
added
Arch: arm
Contributor
Author
|
@cederom ping |
Contributor
|
Uhm, sorry, I am a bit slow and overwhelmed by backlog after service mode, please go ahead wherever necessary!! :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
All I2S driver operation functions say in their signature description that negative errno values are returned on failure. However, some of these same functions had
uint32_treturn types. This would result in incorrect comparison of the return value against signed error code values.Impact
RELEASE
Testing
CI