drivers/timers/watchdog: add missing parameters to watchdog_automonitor_timeout#19426
Closed
Zepp-Hanzj wants to merge 1 commit into
Closed
drivers/timers/watchdog: add missing parameters to watchdog_automonitor_timeout#19426Zepp-Hanzj wants to merge 1 commit into
Zepp-Hanzj wants to merge 1 commit into
Conversation
…or_timeout Fix incomplete implementation of watchdog timeout notifier chain. The function watchdog_automonitor_timeout() was declared with void parameters but used undefined 'action' and 'data' variables in its body when calling atomic_notifier_call_chain(). Add 'action' and 'data' parameters to the function signature in both the implementation and header file. Fixes: 43797ea (drivers/timers/watchdog: add watchdog timer notifier chain) Signed-off-by: hanzhijian <hanzhijian@zepp.com> Author: hanzhijian <hanzhijian@zepp.com>
github-actions
Bot
added
Area: Drivers
Contributor
Author
|
Closing as requested. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix incomplete implementation of watchdog timeout notifier chain.
The function
watchdog_automonitor_timeout()was declared withvoidparameters but used undefinedactionanddatavariables in its body when callingatomic_notifier_call_chain().Add
actionanddataparameters to the function signature in both the implementation and header file.Impact
Testing
Signed-off-by: hanzhijian hanzhijian@zepp.com