{bp-19438} arch/common: fix host_flags_to_mode() O_RDONLY sentinel collision - #19620
Merged
Conversation
host_flags_to_mode() used a trailing 0 entry in modeflags[] as the loop-termination sentinel. O_RDONLY is defined as 0 and is exactly modeflags[1], so the loop's termination check fired before ever comparing that entry, and a bare O_RDONLY open always fell through to -EINVAL. Bound the loop by array size (nitems()) instead of a value sentinel. Signed-off-by: liang.huang <liang.huang@houmo.ai>
jerpelea
requested review from
acassis,
cederom,
linguini1,
lupyuen and
xiaoxiang781216
August 3, 2026 08:19
github-actions
Bot
added
Arch: arm
xiaoxiang781216
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
host_flags_to_mode() used a trailing 0 entry in modeflags[] as the loop-termination sentinel. O_RDONLY is defined as 0 and is exactly modeflags[1], so the loop's termination check fired before ever comparing that entry, and a bare O_RDONLY open always fell through to -EINVAL.
Bound the loop by array size (nitems()) instead of a value sentinel.
Impact
RELEASE
Testing
CI