Skip to content

{bp-19466} video: fix EDID standard timing decode #19626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xiaoxiang781216 merged 1 commit into from
Aug 3, 2026
Merged

{bp-19466} video: fix EDID standard timing decode #19626

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions video/videomode/edid_parse.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,7 @@ static bool edid_std_timing(FAR const uint8_t *stdtim,
unsigned x;
unsigned y;
unsigned f;
uint8_t info;

if ((stdtim[0] == 1 && stdtim[1] == 1) ||
(stdtim[0] == 0 && stdtim[1] == 0) ||
Expand All @@ -133,8 +134,9 @@ static bool edid_std_timing(FAR const uint8_t *stdtim,
return false;
}

x = stdtim[EDID_STDTIMING_XRES_OFFSET];
switch (x & EDID_STDTIMING_ASPECT_MASK)
x = (stdtim[EDID_STDTIMING_XRES_OFFSET] + 31) * 8;
info = stdtim[EDID_STDTIMING_INFO_OFFSET];
switch (info & EDID_STDTIMING_ASPECT_MASK)
{
case EDID_STDTIMING_ASPECT_16_10:
y = x * 10 / 16;
Expand All @@ -154,7 +156,7 @@ static bool edid_std_timing(FAR const uint8_t *stdtim,
break;
}

f = stdtim[EDID_STDTIMING_INFO_OFFSET];
f = (info & ~EDID_STDTIMING_ASPECT_MASK) + 60;

/* First try to lookup the mode as a DMT timing */

Expand Down Expand Up @@ -499,7 +501,7 @@ int edid_parse(FAR const uint8_t *data, FAR struct edid_info_s *edid)
edid->edid_features = data[EDID_DISPLAY_FEATURES_OFFSET];

edid->edid_chroma.ec_redx = EDID_CHROMA_RED_X(data);
edid->edid_chroma.ec_redy = EDID_CHROMA_RED_X(data);
edid->edid_chroma.ec_redy = EDID_CHROMA_RED_Y(data);
edid->edid_chroma.ec_greenx = EDID_CHROMA_GREEN_X(data);
edid->edid_chroma.ec_greeny = EDID_CHROMA_GREEN_Y(data);
edid->edid_chroma.ec_bluex = EDID_CHROMA_BLUE_X(data);
Expand Down
Loading