{bp-19542} arch/arm/nrf52,nrf53: don't pass HCI messages under the lock - #19649
Merged
Conversation
on_hci() ran the host upcall with g_sdc_dev.lock held. On nrf53 this deadlocks the BLE link: the upcall waits for the app core, which cannot answer while bt_hci_send() blocks on the same lock. nrf52 modified for consistency, deadlock is not possible there. Signed-off-by: raiden00pl <raiden00@railab.me> Assisted-by: Claude Code
jerpelea
requested review from
acassis,
cederom,
linguini1,
lupyuen and
xiaoxiang781216
August 3, 2026 10:48
cederom
approved these changes
Aug 3, 2026
acassis
approved these changes
Aug 3, 2026
github-actions
Bot
added
Arch: arm
xiaoxiang781216
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
on_hci() ran the host upcall with g_sdc_dev.lock held. On nrf53 this deadlocks the BLE link: the upcall waits for the app core, which cannot answer while bt_hci_send() blocks on the same lock.
nrf52 modified for consistency, deadlock is not possible there.
Impact
RELEASE
Testing
CI