{bp-19561} boards/rp23xx: add missing rp23xx_st7735.c LCD board glue - #19654
Merged
Conversation
The rp23xx common board sources reference rp23xx_st7735.c from both Make.defs and CMakeLists.txt under CONFIG_LCD_ST7735, but the file was never added. Enabling CONFIG_LCD_ST7735 on any rp23xx board therefore fails the build on the missing source. Add the file, modelled on the existing RP2040 sibling boards/arm/rp2040/common/src/rp2040_st7735.c and retargeted to rp23xx/SPI1. It implements board_lcd_initialize(), board_lcd_getdev() and board_lcd_uninitialize(): bring up SPI1, claim the D/C (shared with the unused SPI1 RX pad, per the rp23xx common convention), RST and BL pads as GPIO, pulse the panel reset and bind the ST7735 driver. Validated on silicon on a Waveshare RP2350-LCD-0.96 (RP2350A + ST7735S 160x80 IPS): the panel powers up and displays correctly, painted at boot with no console interaction. Build-tested raspberrypi-pico-2:nsh with CONFIG_LCD_ST7735=y (compiles and links). Assisted-by: Claude (Anthropic Claude Code) Signed-off-by: Ricard Rosson <ricard@groundbits.com>
jerpelea
requested review from
acassis,
cederom,
linguini1,
lupyuen and
xiaoxiang781216
August 3, 2026 11:03
cederom
approved these changes
Aug 3, 2026
acassis
approved these changes
Aug 3, 2026
github-actions
Bot
added
Size: M
xiaoxiang781216
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The rp23xx common board sources reference rp23xx_st7735.c from both Make.defs and CMakeLists.txt under CONFIG_LCD_ST7735, but the file was never added. Enabling CONFIG_LCD_ST7735 on any rp23xx board therefore fails the build on the missing source.
Add the file, modelled on the existing RP2040 sibling boards/arm/rp2040/common/src/rp2040_st7735.c and retargeted to rp23xx/SPI1. It implements board_lcd_initialize(), board_lcd_getdev() and board_lcd_uninitialize(): bring up SPI1, claim the D/C (shared with the unused SPI1 RX pad, per the rp23xx common convention), RST and BL pads as GPIO, pulse the panel reset and bind the ST7735 driver.
Validated on silicon on a Waveshare RP2350-LCD-0.96 (RP2350A + ST7735S 160x80 IPS): the panel powers up and displays correctly, painted at boot with no console interaction. Build-tested raspberrypi-pico-2:nsh with CONFIG_LCD_ST7735=y (compiles and links).
Impact
RELEASE
Testing
CI