{bp-19563} sched/sched_critmonitor: remove duplicate preemption start block - #19655
Merged
Conversation
The `to->preemp_start = current` assignment when `to->lockcount > 0` was executed twice under CONFIG_SCHED_CRITMONITOR_MAXTIME_PREEMPTION, once in the main preemption block and again after the csection block. Remove the redundant duplicate. Signed-off-by: yushuailong <yyyusl@qq.com>
jerpelea
requested review from
acassis,
cederom,
linguini1,
lupyuen and
xiaoxiang781216
August 3, 2026 11:05
cederom
approved these changes
Aug 3, 2026
acassis
approved these changes
Aug 3, 2026
github-actions
Bot
added
Area: OS Components
xiaoxiang781216
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
to->preemp_start = currentassignment whento->lockcount > 0was executed twice under CONFIG_SCHED_CRITMONITOR_MAXTIME_PREEMPTION, once in the main preemption block and again after the csection block. Remove the redundant duplicate.Impact
RELEASE
Testing
CI