{bp-19373} drivers/i2s/i2schar: Fix return types - #19671
Merged
Merged
Conversation
This commit fixes the incorrect casting of signed types to unsigned types in the I2S character driver. NOTE: the I2S character driver IOCTLs retain their original argument types. This is fine, because errors are reported through errno by the ioctl call. The returned value in the 'arg' parameter is to be ignored when the call results in an error. Outside of error codes, all i2s interfaces return unsigned values. Signed-off-by: Matteo Golin <matteo.golin@gmail.com>
jerpelea
requested review from
acassis,
cederom,
linguini1,
lupyuen and
xiaoxiang781216
August 3, 2026 13:01
cederom
approved these changes
Aug 3, 2026
github-actions
Bot
added
Area: Drivers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This commit fixes the incorrect casting of signed types to unsigned types in the I2S character driver.
NOTE: the I2S character driver IOCTLs retain their original argument types. This is fine, because errors are reported through errno by the ioctl call. The returned value in the 'arg' parameter is to be ignored when the call results in an error. Outside of error codes, all i2s interfaces return unsigned values.
Impact
RELEASE
Testing
CI