arch/arm/stm32h5/serial: fix UART8 buffer guard typo - #19701
Merged
Conversation
Use CONFIG_STM32_UART8_SERIALDRIVER so g_uart8rxbuffer and g_uart8txbuffer are compiled when UART8 is enabled. Signed-off-by: Joao Mario Lago <joao.mario.lago@hotmail.com>
acassis
approved these changes
Aug 5, 2026
xiaoxiang781216
approved these changes
Aug 5, 2026
patrickelectric
approved these changes
Aug 5, 2026
hartmannathan
approved these changes
Aug 5, 2026
hartmannathan
left a comment
Contributor
There was a problem hiding this comment.
Good catch! Thank you
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In
stm32h5/stm32_serial.c, the UART8 RX/TX buffer definitions were guarded byCONFIG_STM32H8_UART8_SERIALDRIVER(typo). The rest of the UART8 serial instance correctly usesCONFIG_STM32_UART8_SERIALDRIVER.This change corrects the guard to
CONFIG_STM32_UART8_SERIALDRIVERso the buffers are compiled with the UART8 driver.Impact
CONFIG_STM32_UART8_SERIALDRIVERis enabled.Testing
Tested compiling
nucleo-h563zi:nshwith UART8 configured (together with the Kconfig fix from #19700).Board code patch used for this test: nucleo-h563zi-nsh-uart8-typo-test.patch
Build configuration:
Without this change (Compilation fails)
With this change (Compilation succeeds)
cmake --build build [1162/1164] Linking CXX executable nuttx Memory region Used Size Region Size %age Used flash: 227392 B 2 MB 10.84% sram: 10512 B 256 KB 4.01% [1164/1164] Generating System.map