tools/Unix.mk: add nuttx.asm to manifest - #20051
Merged
Merged
Conversation
Fix bug where "nuttx.bin" was written to nuttx.asm instead of appending nuttx.asm to nuttx.manifest Signed-off-by: Antoine Juckler <ajuckler@users.noreply.github.com>
github-actions
Bot
added
Area: Build system
Size: XS
xiaoxiang781216
approved these changes
Sep 3, 2026
Contributor
|
Welcome back @ajuckler !!! |
acassis
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add "nuttx.asm" to nuttx.manifest when CONFIG_RAW_DISASSEMBLY is enabled
Impact
Testing
Compiled for a custom target (STM32F7-based) with arm-none-eabi-gcc 13.2.1 and CONFIG_RAW_DISASSEMBLY enabled.
I could confirm the behaviour described in the Impact section