Skip to content

Documented: per-component test.api.enabled gate on runExampleTestSuite #373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ashishvijaywargiya merged 2 commits into from
Aug 21, 2026
Merged

Documented: per-component test.api.enabled gate on runExampleTestSuite #373

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fc2f793
Document per-component test.api.enabled.example gate on runExampleTes…
ashishvijaywargiya Aug 21, 2026
3105d6f
Fix CodeNarc BlockStartsWithBlankLine violations in ExampleJupiterTests
ashishvijaywargiya Aug 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions example/servicedef/services.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,10 +185,13 @@ under the License.
<description>Kicks off a testdef test-suite run asynchronously, scoped to the example
component only - see TestRunServices.runScopedTestSuite. Gated by the test.api.enabled
config flag and the TESTEXEC_ADMIN permission (checked inside the underlying service).
componentName is deliberately not an attribute here - the component is fixed, not
caller-suppliable. testMethodName optionally scopes the run to one
@Test/@ParameterizedTest method within the class testCaseName resolves to - requires
testCaseName, and only applies when it resolves to a jupiter-test-suite.</description>
Also gated by the per-component test.api.enabled.example override - same
SystemProperty-backed mechanism, defaults to enabled, lets this component's endpoint be
disabled independently of every other component's. componentName is deliberately not an
attribute here - the component is fixed, not caller-suppliable. testMethodName optionally
scopes the run to one @Test/@ParameterizedTest method within the class testCaseName
resolves to - requires testCaseName, and only applies when it resolves to a
jupiter-test-suite.</description>
<attribute name="suiteName" type="String" mode="IN" optional="false"/>
<attribute name="testCaseName" type="String" mode="IN" optional="true"/>
<attribute name="testMethodName" type="String" mode="IN" optional="true"/>
Expand Down
3 changes: 0 additions & 3 deletions example/src/test/groovy/org/apache/ofbiz/example/test/ExampleJupiterTests.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@ class ExampleJupiterTests implements JupiterTestHelper {
@Test
@Order(1)
void shouldCreateExample() {

GenericValue userLogin = delegator.findOne('UserLogin', [userLoginId: 'system'], false)

String exampleTypeId = testParams.exampleTypeId ?: 'CONTRIVED'
Expand All @@ -76,7 +75,6 @@ class ExampleJupiterTests implements JupiterTestHelper {
@Test
@Order(6)
void shouldUpdateExample() {

GenericValue userLogin = delegator.findOne('UserLogin', [userLoginId: 'system'], false)

String exampleTypeId = testParams.exampleTypeId ?: 'CONTRIVED'
Expand Down Expand Up @@ -140,7 +138,6 @@ class ExampleJupiterTests implements JupiterTestHelper {
@Test
@Order(3)
void shouldDeleteExample() {

GenericValue userLogin = delegator.findOne('UserLogin', [userLoginId: 'system'], false)

String exampleTypeId = testParams.exampleTypeId ?: 'CONTRIVED'
Expand Down